-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] All samples unified switch to annotation + yaml configuration … #1128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CrazyHZM PTAL
@cnzakii Please fix the ci. |
@CrazyHZM
|
...tensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml
Show resolved
Hide resolved
dubbo: | ||
application: | ||
# Specify the application name of Dubbo | ||
name: extensibility-filter-provider | ||
protocol: | ||
# Specify the port of Dubbo protocol | ||
port: 20881 | ||
provider: | ||
# Apply AppendedFilter | ||
filter: appended | ||
# Enable token verification for each invocation | ||
token: true | ||
registry: | ||
# Specify the registry address | ||
address: nacos://localhost:8848?username=nacos&password=nacos | ||
# address: nacos://localhost:8848?username=nacos&password=nacos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this configuration file only a new, no-removed properties file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cnzakii My meaning is we should remove the application.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CrazyHZM
My reply above is explaining that I have deleted application.properties
.
But I don’t know why it is not shown here that application.properties
has been deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I checked your branch, and it is ok; it seems to be a GitHub issue.
@cnzakii For new contributors to the community, we would prefer to see as small a PR as possible for one or a few modules, as this is easier to review and can be merged faster. |
OK, I get it, thanks for reminding me |
OK, I will close this "massive" pull request and submit new pull requests module by module. |
What is the purpose of the change
[Task] All samples unified switch to annotation + yaml configuration #13860
Brief changelog
Convert all
application.properties
intoapplication.yml
Verifying this change
Checklist