We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
// ZookeeperDynamicConfiguration @Override protected void doRemoveListener(String pathKey, ConfigurationListener listener) { Set<ConfigurationListener> configurationListeners = cacheListener.getConfigurationListeners(pathKey); // 为什么要把整个cacheListener都删掉? if (CollectionUtils.isNotEmpty(configurationListeners)) { zkClient.removeDataListener(pathKey, cacheListener); } cacheListener.removeListener(pathKey, listener); }
为什么删除pathKey中的一个ConfigurationListener要把整个cacheListener都删掉?这样不是相当于这个pathKey下所有的ConfigurationListener都失效了吗?
不知道是不是下面这个逻辑比较合理
@Override protected void doRemoveListener(String pathKey, ConfigurationListener listener) { cacheListener.removeListener(pathKey, listener); Set<ConfigurationListener> configurationListeners = cacheListener.getConfigurationListeners(pathKey); if (CollectionUtils.isEmpty(configurationListeners)) { zkClient.removeDataListener(pathKey, cacheListener); } }
The text was updated successfully, but these errors were encountered:
yes, you are right, i will fix it.
Sorry, something went wrong.
fix #10059, fix ZookeeperDynamicConfiguration remove cache listener m…
edd3d28
…istake (#10106) Co-authored-by: 呈铭 <beck.wcm@antgroup.com>
Resolved in #10106
No branches or pull requests
Ask your question here
为什么删除pathKey中的一个ConfigurationListener要把整个cacheListener都删掉?这样不是相当于这个pathKey下所有的ConfigurationListener都失效了吗?
不知道是不是下面这个逻辑比较合理
The text was updated successfully, but these errors were encountered: