Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] fix ZookeeperDynamicConfiguration remove cache listener mistake #10106

Merged
merged 1 commit into from
Jun 6, 2022
Merged

[2.7] fix ZookeeperDynamicConfiguration remove cache listener mistake #10106

merged 1 commit into from
Jun 6, 2022

Conversation

wangchengming666
Copy link
Member

fix #10059, fix ZookeeperDynamicConfiguration remove cache listener mistake

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #10106 (fdd0d47) into master (c25284e) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #10106      +/-   ##
============================================
+ Coverage     60.50%   60.89%   +0.39%     
- Complexity      412      448      +36     
============================================
  Files          1100     1100              
  Lines         44557    44557              
  Branches       6485     6485              
============================================
+ Hits          26959    27133     +174     
+ Misses        14637    14455     -182     
- Partials       2961     2969       +8     
Impacted Files Coverage Δ
...pport/zookeeper/ZookeeperDynamicConfiguration.java 60.00% <100.00%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 51.97% <0.00%> (-1.13%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-0.91%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.14% <0.00%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 80.41% <0.00%> (+0.20%) ⬆️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.81% <0.00%> (+0.32%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 63.85% <0.00%> (+0.35%) ⬆️
...org/apache/dubbo/registry/redis/RedisRegistry.java 58.42% <0.00%> (+0.37%) ⬆️
...pache/dubbo/remoting/telnet/codec/TelnetCodec.java 51.23% <0.00%> (+0.61%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25284e...fdd0d47. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants