Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/remove-parse-error-log #3862

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

lexburner
Copy link
Contributor

What is the purpose of the change

there is no need for any log in DubboBeanDefinitionParser since some class implements the interface: EnvironmentAware, ApplicationAware, etc. They only have setter methods, otherwise will cause the error log during application startup.

Brief changelog

remove the error log

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The error log added before was unnecessary and misleading.

@chickenlj chickenlj merged commit 68e5522 into apache:master Apr 12, 2019
@lexburner lexburner deleted the bugfix/remove-parse-error-log branch April 12, 2019 03:17
@CrazyHZM
Copy link
Member

I also submitted this part of the fix before, then I closed my submission. #3844

@codecov-io
Copy link

Codecov Report

Merging #3862 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3862      +/-   ##
============================================
- Coverage     63.59%   63.58%   -0.02%     
  Complexity       71       71              
============================================
  Files           708      708              
  Lines         31196    31195       -1     
  Branches       5048     5048              
============================================
- Hits          19839    19834       -5     
- Misses         9074     9080       +6     
+ Partials       2283     2281       -2
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/schema/DubboBeanDefinitionParser.java 67.27% <ø> (-0.15%) 0 <0> (ø)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.82% <0%> (+2.04%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48a045...9f4c855. Read the comment docs.

vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants