Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Improve compressed URL param performance #10125

Merged
merged 5 commits into from Jun 13, 2022

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 7, 2022

What is the purpose of the change

assume key is in constant pool, improve performance

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #10125 (423b0f4) into 3.0 (4689fef) will decrease coverage by 0.09%.
The diff coverage is 93.90%.

@@             Coverage Diff              @@
##                3.0   #10125      +/-   ##
============================================
- Coverage     65.74%   65.64%   -0.10%     
+ Complexity      320      297      -23     
============================================
  Files          1220     1220              
  Lines         53144    53114      -30     
  Branches       8057     8034      -23     
============================================
- Hits          34937    34869      -68     
- Misses        14393    14427      +34     
- Partials       3814     3818       +4     
Impacted Files Coverage Δ
...bo/common/url/component/param/FixedParamValue.java 81.25% <ø> (-1.11%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 78.12% <83.33%> (-1.05%) ⬇️
...rg/apache/dubbo/common/url/component/URLParam.java 89.81% <95.45%> (+2.20%) ⬆️
.../common/url/component/param/DynamicParamTable.java 90.24% <95.83%> (+1.67%) ⬆️
...ache/dubbo/common/url/component/URLPlainParam.java 100.00% <100.00%> (ø)
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../dubbo/rpc/protocol/tri/command/QueuedCommand.java 64.28% <0.00%> (-14.29%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...ian2/dubbo/AbstractHessian2FactoryInitializer.java 50.00% <0.00%> (-11.12%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4689fef...423b0f4. Read the comment docs.

@AlbumenJ AlbumenJ requested a review from chickenlj June 9, 2022 03:05
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 67e36cd into apache:3.0 Jun 13, 2022
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
guohao pushed a commit to guohao/dubbo that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants