Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 10405: if the parameter contains Spaces, the invoke telnet command will fail. #10669

Merged
merged 2 commits into from Sep 26, 2022

Conversation

pandaapo
Copy link
Contributor

What is the purpose of the change

Fixes #10405.

Brief changelog

When use telnet command invoke that has args containing Space in method, no invalid parameters error will be reported.

Verifying this change

Use telnet to connect to dubbo provider: telnet {ip} {port}.
Invoke the service exported with telnet command: invoke {service name}.{method name}({args that contain Space})

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #10669 (cff7952) into 3.1 (2bed0af) will decrease coverage by 0.68%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##                3.1   #10669      +/-   ##
============================================
- Coverage     65.22%   64.53%   -0.69%     
+ Complexity      471      470       -1     
============================================
  Files          1336     1336              
  Lines         56922    56915       -7     
  Branches       8435     8409      -26     
============================================
- Hits          37128    36732     -396     
- Misses        15826    16198     +372     
- Partials       3968     3985      +17     
Impacted Files Coverage Δ
...ubbo/qos/command/decoder/TelnetCommandDecoder.java 60.00% <40.00%> (-12.73%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...sian2/dubbo/DefaultHessian2FactoryInitializer.java 0.00% <0.00%> (-100.00%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
...o/rpc/cluster/router/script/ScriptStateRouter.java 0.00% <0.00%> (-67.31%) ⬇️
...ian2/dubbo/AbstractHessian2FactoryInitializer.java 0.00% <0.00%> (-61.12%) ⬇️
...ize/hessian2/dubbo/Hessian2FactoryInitializer.java 0.00% <0.00%> (-60.00%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 15.38% <0.00%> (-55.13%) ⬇️
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 14fb253 into apache:3.1 Sep 26, 2022
@pandaapo pandaapo deleted the 3.1-issue10405 branch September 27, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telnet invoke api failed:Invalid parameters, format: service.method(args)
3 participants