Remove netty-all dependency
#10818
Merged
Remove netty-all dependency
#10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AlbumenJ
requested changes
Oct 25, 2022
dubbo-dependencies-bom/pom.xml
Outdated
Comment on lines
221
to
265
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-codec</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-handler</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-codec-http2</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- </dependency>--> | ||
|
|
||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-transport-native-epoll</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- <classifier>linux-x86_64</classifier>--> | ||
| <!-- <scope>runtime</scope>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-transport-native-epoll</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- <classifier>linux-aarch_64</classifier>--> | ||
| <!-- <scope>runtime</scope>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-transport-native-kqueue</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- <classifier>osx-x86_64</classifier>--> | ||
| <!-- <scope>runtime</scope>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.netty</groupId>--> | ||
| <!-- <artifactId>netty-transport-native-kqueue</artifactId>--> | ||
| <!-- <version>${netty4_version}</version>--> | ||
| <!-- <classifier>osx-aarch_64</classifier>--> | ||
| <!-- <scope>runtime</scope>--> | ||
| <!-- </dependency>--> | ||
|
|
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-epoll</artifactId> | ||
| <version>4.1.72.Final</version> |
There was a problem hiding this comment.
version should be managed in dubbo-dependenies-bom
Comment on lines
1
to
299
|
|
||
| @Override | ||
| public void onError(Throwable throwable) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| observer.onCompleted(); | ||
| } | ||
| }); | ||
| return result; | ||
| }); | ||
| MethodDescriptor method = Mockito.mock(MethodDescriptor.class); | ||
| when(method.getParameterClasses()) | ||
| .thenReturn(new Class[]{String.class}); | ||
| when(method.getMethodName()) | ||
| .thenReturn("sayHello"); | ||
| String request = "request"; | ||
| CountDownLatch latch = new CountDownLatch(11); | ||
| StreamObserver<Object> responseObserver = new StreamObserver<Object>() { | ||
| @Override | ||
| public void onNext(Object data) { | ||
| latch.countDown(); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable throwable) { | ||
| } | ||
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| latch.countDown(); | ||
| } | ||
| }; | ||
| StreamObserver<Object> observer = StubInvocationUtil.biOrClientStreamCall(invoker, method, | ||
| responseObserver); | ||
| for (int i = 0; i < 10; i++) { | ||
| observer.onNext(request); | ||
| } | ||
| observer.onCompleted(); | ||
| Assertions.assertTrue(latch.await(1, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| @Test | ||
| void serverStreamCall() throws InterruptedException { | ||
| Invoker<DemoService> invoker = Mockito.mock(Invoker.class); | ||
| URL url = Mockito.mock(URL.class); | ||
| ConsumerModel consumerModel = Mockito.mock(ConsumerModel.class); | ||
| ServiceDescriptor serviceDescriptor = Mockito.mock(ServiceDescriptor.class); | ||
| when(consumerModel.getServiceModel()).thenReturn(serviceDescriptor); | ||
| when(url.getServiceModel()) | ||
| .thenReturn(consumerModel); | ||
| when(url.getServiceInterface()) | ||
| .thenReturn(DemoService.class.getName()); | ||
| when(url.getProtocolServiceKey()) | ||
| .thenReturn(DemoService.class.getName()); | ||
| when(invoker.getUrl()) | ||
| .thenReturn(url); | ||
| when(invoker.getInterface()) | ||
| .thenReturn(DemoService.class); | ||
| Result result = Mockito.mock(Result.class); | ||
| String response = "response"; | ||
| when(invoker.invoke(any(Invocation.class))) | ||
| .then(invocationOnMock -> { | ||
| Invocation invocation = (Invocation) invocationOnMock.getArguments()[0]; | ||
| StreamObserver<Object> observer = (StreamObserver<Object>) invocation.getArguments()[1]; | ||
| for (int i = 0; i < 10; i++) { | ||
| observer.onNext(response); | ||
| } | ||
| observer.onCompleted(); | ||
| return result; | ||
| }); | ||
| MethodDescriptor method = Mockito.mock(MethodDescriptor.class); | ||
| when(method.getParameterClasses()) | ||
| .thenReturn(new Class[]{String.class}); | ||
| when(method.getMethodName()) | ||
| .thenReturn("sayHello"); | ||
| String request = "request"; | ||
| CountDownLatch latch = new CountDownLatch(11); | ||
| StreamObserver<Object> responseObserver = new StreamObserver<Object>() { | ||
| @Override | ||
| public void onNext(Object data) { | ||
| latch.countDown(); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable throwable) { | ||
| } | ||
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| latch.countDown(); | ||
| } | ||
| }; | ||
| StubInvocationUtil.serverStreamCall(invoker, method, request, responseObserver); | ||
| Assertions.assertTrue(latch.await(1, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| } |
Comment on lines
1
to
22
| ///* | ||
| // * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| // * contributor license agreements. See the NOTICE file distributed with | ||
| // * this work for additional information regarding copyright ownership. | ||
| // * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| // * (the "License"); you may not use this file except in compliance with | ||
| // * the License. You may obtain a copy of the License at | ||
| // * | ||
| // * http://www.apache.org/licenses/LICENSE-2.0 | ||
| // * | ||
| // * Unless required by applicable law or agreed to in writing, software | ||
| // * distributed under the License is distributed on an "AS IS" BASIS, | ||
| // * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // * See the License for the specific language governing permissions and | ||
| // * limitations under the License. | ||
| // */ | ||
| // | ||
| //package org.apache.dubbo.rpc; | ||
| // | ||
| //import org.apache.dubbo.common.URL; | ||
| //import org.apache.dubbo.common.stream.StreamObserver; | ||
| //import org.apache.dubbo.rpc.model.ConsumerModel; |
AlbumenJ
requested changes
Oct 25, 2022
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-epoll</artifactId> | ||
| <classifier>linux-x86_64</classifier> |
There was a problem hiding this comment.
should this filed change to os auto detected
Codecov Report
@@ Coverage Diff @@
## 3.1 #10818 +/- ##
============================================
- Coverage 67.87% 64.53% -3.35%
+ Complexity 510 469 -41
============================================
Files 1348 1336 -12
Lines 66361 57004 -9357
Branches 11234 8405 -2829
============================================
- Hits 45045 36786 -8259
+ Misses 16981 16262 -719
+ Partials 4335 3956 -379
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
Verifying this change
Checklist