New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #10958 and polish duplicates code #11102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been fixed |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.1 #11102 +/- ##
============================================
- Coverage 69.36% 64.56% -4.80%
+ Complexity 126 14 -112
============================================
Files 1496 1421 -75
Lines 79326 59397 -19929
Branches 14007 8733 -5274
============================================
- Hits 55023 38349 -16674
+ Misses 19527 16998 -2529
+ Partials 4776 4050 -726
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
good job |
What is the purpose of the change
fix #10958 and polish duplicates code
Brief changelog
Verifying this change
Checklist