Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10958 and polish duplicates code #11102

Merged
merged 5 commits into from Dec 15, 2022
Merged

fix #10958 and polish duplicates code #11102

merged 5 commits into from Dec 15, 2022

Conversation

ShenFeng312
Copy link
Contributor

@ShenFeng312 ShenFeng312 commented Dec 9, 2022

What is the purpose of the change

fix #10958 and polish duplicates code

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please fix uts

@ShenFeng312
Copy link
Contributor Author

image

Please fix uts

OK~

@ShenFeng312
Copy link
Contributor Author

ShenFeng312 commented Dec 15, 2022

it has been fixed

@ShenFeng312
Copy link
Contributor Author

it bas been fixed

@AlbumenJ

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

47.4% 47.4% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11102 (3c18fe2) into 3.1 (e219c1f) will decrease coverage by 4.79%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##                3.1   #11102      +/-   ##
============================================
- Coverage     69.36%   64.56%   -4.80%     
+ Complexity      126       14     -112     
============================================
  Files          1496     1421      -75     
  Lines         79326    59397   -19929     
  Branches      14007     8733    -5274     
============================================
- Hits          55023    38349   -16674     
+ Misses        19527    16998    -2529     
+ Partials       4776     4050     -726     
Impacted Files Coverage Δ
...n/java/org/apache/dubbo/metadata/MetadataInfo.java 77.41% <66.66%> (-2.40%) ⬇️
...ient/metadata/ProtocolPortsMetadataCustomizer.java 88.88% <100.00%> (+6.53%) ⬆️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 63.63% <100.00%> (-23.64%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
... and 490 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit b201cb0 into apache:3.1 Dec 15, 2022
@shihy0923
Copy link

it bas been fixed

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants