testHashCode is a flaky Test #11115
Open
testHashCode is a flaky Test #11115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## 3.1 #11115 +/- ##
============================================
- Coverage 69.37% 64.54% -4.84%
+ Complexity 125 14 -111
============================================
Files 1485 1420 -65
Lines 77575 59087 -18488
Branches 13588 8673 -4915
============================================
- Hits 53820 38139 -15681
+ Misses 19036 16901 -2135
+ Partials 4719 4047 -672
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
requested changes
Dec 12, 2022
| @@ -1023,7 +1023,7 @@ void testHashcode() { | |||
| URL url2 = URL.valueOf("consumer://30.225.20.150/org.apache.dubbo.rpc.service.GenericService?application=" + | |||
| "dubbo-demo-api-consumer&category=consumers&check=false&dubbo=2.0.2&generic=true&interface=" + | |||
| "org.apache.dubbo.demo.DemoService&pid=7375&side=consumer&sticky=false×tamp=2299556506417"); | |||
| assertEquals(url1.hashCode(), url2.hashCode()); | |||
| assertTrue(url1.equals(url2) && url2.equals(url1)); | |||
There was a problem hiding this comment.
The test case here is to check the hashCode are the same.
For equals test, is in other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Correcting the testHashCode test to make it can pass nondex check
Brief changelog
Verifying this change
Checklist