-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #11033 #11144
fix #11033 #11144
Conversation
目前 已dubbo 的参数做参照传递 看了下GRPC 也是调用org.apache.dubbo.rpc.protocol.AbstractInvoker#AbstractInvoker(java.lang.Class, org.apache.dubbo.common.URL)这个方法 可能也有相同情况 |
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/proxy/AbstractProxyInvoker.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ContextFilter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 3.2 #11144 +/- ##
=========================================
Coverage 64.77% 64.78%
Complexity 14 14
=========================================
Files 1479 1479
Lines 61596 61617 +21
Branches 9031 9033 +2
=========================================
+ Hits 39901 39916 +15
- Misses 17503 17515 +12
+ Partials 4192 4186 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rpcInvocation.setObjectAttachments(new HashMap<>(RpcContext.getServerAttachment().getObjectAttachments())); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the conflicts with 3.2
branch.
The changes may break users. So, I think we should merge it into 3.2
branch.
所以需要我把我的commit改都3.2分支吗 不好意思前几天新冠比较严重没有看到 |
Kudos, SonarCloud Quality Gate passed! |
There are still some errors, but I don't know how to solve them |
They are not cause by this PR. I will merge this PR later. Thanks for your contribution. |
@ShenFeng312 Would you please add some integration test cases in apache/dubbo-samples to verify this PR? |
|
What is the purpose of the change
Brief changelog
Verifying this change
Checklist