Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11033 #11144

Merged
merged 10 commits into from
Dec 30, 2022
Merged

fix #11033 #11144

merged 10 commits into from
Dec 30, 2022

Conversation

ShenFeng312
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@ShenFeng312
Copy link
Contributor Author

目前 已dubbo 的参数做参照传递 看了下GRPC 也是调用org.apache.dubbo.rpc.protocol.AbstractInvoker#AbstractInvoker(java.lang.Class, org.apache.dubbo.common.URL)这个方法 可能也有相同情况

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #11144 (f1fb66d) into 3.2 (f5df7ed) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff            @@
##                3.2   #11144   +/-   ##
=========================================
  Coverage     64.77%   64.78%           
  Complexity       14       14           
=========================================
  Files          1479     1479           
  Lines         61596    61617   +21     
  Branches       9031     9033    +2     
=========================================
+ Hits          39901    39916   +15     
- Misses        17503    17515   +12     
+ Partials       4192     4186    -6     
Impacted Files Coverage Δ
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 69.51% <0.00%> (-0.57%) ⬇️
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 66.17% <ø> (-0.50%) ⬇️
...ache/dubbo/rpc/protocol/rest/RpcContextFilter.java 60.00% <60.00%> (-1.12%) ⬇️
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 60.00% <78.57%> (+2.04%) ⬆️
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 82.35% <100.00%> (+0.26%) ⬆️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 67.30% <100.00%> (+0.97%) ⬆️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 84.84% <0.00%> (-6.07%) ⬇️
...bo/remoting/zookeeper/AbstractZookeeperClient.java 81.60% <0.00%> (-3.45%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 73.57% <0.00%> (-2.15%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 67.77% <0.00%> (-1.12%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShenFeng312 ShenFeng312 requested review from AlbumenJ and wxbty and removed request for AlbumenJ and wxbty December 19, 2022 04:37
Comment on lines 73 to 74
rpcInvocation.setObjectAttachments(new HashMap<>(RpcContext.getServerAttachment().getObjectAttachments()));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Wrap invoker would be better.

See org/apache/dubbo/rpc/protocol/AbstractProxyProtocol.java:91

@AlbumenJ AlbumenJ changed the base branch from 3.1 to 3.2 December 21, 2022 15:26
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflicts with 3.2 branch.
The changes may break users. So, I think we should merge it into 3.2 branch.

@ShenFeng312
Copy link
Contributor Author

Please fix the conflicts with 3.2 branch. The changes may break users. So, I think we should merge it into 3.2 branch.

所以需要我把我的commit改都3.2分支吗 不好意思前几天新冠比较严重没有看到

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@ShenFeng312
Copy link
Contributor Author

There are still some errors, but I don't know how to solve them

@AlbumenJ
Copy link
Member

There are still some errors, but I don't know how to solve them

They are not cause by this PR. I will merge this PR later. Thanks for your contribution.

@AlbumenJ
Copy link
Member

@ShenFeng312 Would you please add some integration test cases in apache/dubbo-samples to verify this PR?

@ShenFeng312
Copy link
Contributor Author

ShenFeng312 commented Jan 6, 2023

@ShenFeng312 Would you please add some integration test cases in apache/dubbo-samples to verify this PR?

@AlbumenJ done apache/dubbo-samples#698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants