Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invokers has changed when router chain switch #11248

Merged
merged 7 commits into from
Jan 14, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jan 6, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #11248 (320d7e9) into 3.2 (0419f25) will increase coverage by 0.06%.
The diff coverage is 65.97%.

@@             Coverage Diff              @@
##                3.2   #11248      +/-   ##
============================================
+ Coverage     65.04%   65.10%   +0.06%     
  Complexity       14       14              
============================================
  Files          1479     1484       +5     
  Lines         61745    62119     +374     
  Branches       9045     9109      +64     
============================================
+ Hits          40160    40442     +282     
- Misses        17374    17460      +86     
- Partials       4211     4217       +6     
Impacted Files Coverage Δ
...rg/apache/dubbo/rpc/cluster/SingleRouterChain.java 53.74% <46.15%> (-0.63%) ⬇️
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 77.02% <59.37%> (+0.63%) ⬆️
...e/dubbo/rpc/cluster/directory/StaticDirectory.java 66.66% <66.66%> (+0.75%) ⬆️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 78.19% <71.79%> (-3.41%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 43.94% <100.00%> (-0.20%) ⬇️
...e/dubbo/registry/integration/DynamicDirectory.java 61.94% <100.00%> (ø)
.../dubbo/registry/integration/RegistryDirectory.java 51.55% <100.00%> (-0.17%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 72.41% <0.00%> (-6.90%) ⬇️
...oting/transport/netty4/NettyConnectionHandler.java 53.19% <0.00%> (-6.39%) ⬇️
...bbo/rpc/cluster/support/ForkingClusterInvoker.java 80.95% <0.00%> (-4.77%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

52.9% 52.9% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit b566879 into apache:3.2 Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants