Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 jvm meter add application name label #11255

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

馃帹 jvm meter add application name label
fix #11232

Brief changelog

馃帹 jvm meter add application name label

Verifying this change

image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM
Copy link
Member

CrazyHZM commented Jan 9, 2023

@songxiaosheng Please fix the unit test.

@songxiaosheng
Copy link
Member Author

@songxiaosheng Please fix the unit test.

has fixed

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

SonarCloud Quality Gate failed.聽 聽 Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM added this to the 3.2.0 milestone Jan 10, 2023
@CrazyHZM CrazyHZM merged commit b7b7ddf into apache:3.2 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observability tasks: complement all JVM metrics and application information
2 participants