Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dubbo prefix(dubbo.provider) to dubbo's provider. #11295

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

fomeiherz
Copy link
Contributor

What is the purpose of the change

Add dubbo prefix(dubbo.provider) to dubbo's provider.
Link issue: #11252

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@songxiaosheng
Copy link
Member

ok

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11295 (93abf3b) into 3.2 (21b68b6) will decrease coverage by 4.60%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.2   #11295      +/-   ##
============================================
- Coverage     69.74%   65.13%   -4.61%     
+ Complexity      119       14     -105     
============================================
  Files          1513     1485      -28     
  Lines         80910    62088   -18822     
  Branches      14354     9107    -5247     
============================================
- Hits          56430    40442   -15988     
+ Misses        19671    17441    -2230     
+ Partials       4809     4205     -604     
Impacted Files Coverage Δ
...mon/metrics/collector/DefaultMetricsCollector.java 98.82% <100.00%> (-0.17%) ⬇️
.../apache/dubbo/common/metrics/model/MetricsKey.java 100.00% <100.00%> (ø)
...o/metrics/collector/AggregateMetricsCollector.java 86.30% <100.00%> (-7.52%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
... and 464 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants