-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xdsroute observe logic #11309
Add xdsroute observe logic #11309
Conversation
# Conflicts: # dubbo-xds/src/main/java/org/apache/dubbo/registry/xds/util/PilotExchanger.java # dubbo-xds/src/main/java/org/apache/dubbo/registry/xds/util/protocol/impl/LdsProtocol.java
import java.util.Set; | ||
import org.apache.dubbo.rpc.cluster.router.xds.rule.*; | ||
|
||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use import *
@@ -108,9 +114,21 @@ private void createRouteObserve() { | |||
} | |||
|
|||
public static PilotExchanger initialize(URL url) { | |||
return new PilotExchanger(url); | |||
synchronized (PilotExchanger.class){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lock is better
fix code style
…to develop-3.2-xds
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.2 #11309 +/- ##
============================================
- Coverage 65.20% 65.13% -0.07%
Complexity 14 14
============================================
Files 1485 1485
Lines 62227 62270 +43
Branches 9122 9128 +6
============================================
- Hits 40573 40561 -12
- Misses 17447 17492 +45
- Partials 4207 4217 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What is the purpose of the change
Brief changelog
Verifying this change
Checklist