Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triple serialize check #11984

Merged
merged 4 commits into from Apr 6, 2023
Merged

triple serialize check #11984

merged 4 commits into from Apr 6, 2023

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen EarthChen requested a review from AlbumenJ April 2, 2023 09:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Merging #11984 (d32b943) into 3.1 (f57dbcf) will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                3.1   #11984      +/-   ##
============================================
+ Coverage     64.69%   64.72%   +0.02%     
  Complexity       14       14              
============================================
  Files          1433     1433              
  Lines         60076    60086      +10     
  Branches       8830     8831       +1     
============================================
+ Hits          38868    38891      +23     
+ Misses        17132    17120      -12     
+ Partials       4076     4075       -1     
Impacted Files Coverage Δ
.../apache/dubbo/remoting/transport/CodecSupport.java 77.14% <25.00%> (-3.17%) ⬇️
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 82.05% <100.00%> (+0.56%) ⬆️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.9% 57.9% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ changed the title triple security check triple serialize check Apr 2, 2023
@AlbumenJ AlbumenJ merged commit 0364745 into apache:3.1 Apr 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants