New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dubbo3.2 add rest client tls #12251
base: 3.3
Are you sure you want to change the base?
Feature/dubbo3.2 add rest client tls #12251
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.3 #12251 +/- ##
============================================
- Coverage 68.40% 68.18% -0.22%
Complexity 5 5
============================================
Files 1636 1648 +12
Lines 67469 68030 +561
Branches 9835 9895 +60
============================================
+ Hits 46152 46387 +235
- Misses 16849 17133 +284
- Partials 4468 4510 +42 see 64 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…_tls' into feature/dubbo3.2_add_rest_client_tls
...bo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/ssl/RestClientSSLContexts.java
Fixed
Show fixed
Hide fixed
.../dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/ssl/SSLContextBuilder.java
Fixed
Show fixed
Hide fixed
.../dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/ssl/SSLContextBuilder.java
Fixed
Show fixed
Hide fixed
|
||
import static org.apache.dubbo.common.constants.LoggerCodeConstants.TRANSPORT_FAILED_CLOSE_STREAM; | ||
|
||
public class JDKSSLUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public class JDKSSLUtils { | |
public class JdkSslUtils { |
import java.io.OutputStream; | ||
import java.io.PushbackInputStream; | ||
|
||
public class BASE64Decoder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java.util.Base64
is enough?
dubbo-common/src/main/java/org/apache/dubbo/common/ssl/util/JDKSSLUtils.java
Fixed
Show fixed
Hide fixed
dubbo-common/src/main/java/org/apache/dubbo/common/ssl/util/JDKSSLUtils.java
Fixed
Show fixed
Hide fixed
...bo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/ssl/RestClientSSLContexts.java
Fixed
Show fixed
Hide fixed
…_tls' into feature/dubbo3.2_add_rest_client_tls
Kudos, SonarCloud Quality Gate passed! |
|
||
public boolean isPem() { | ||
return isPem; | ||
} | ||
|
||
public void setPem(boolean pem) { | ||
isPem = pem; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to match from context with regex?
@CrazyHZM @EarthChen PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Add more ut & it is better.
What is the purpose of the change
add rest client tls
Brief changelog
Verifying this change
@AlbumenJ
Checklist