Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dubbo3.2 add rest client tls #12251

Open
wants to merge 34 commits into
base: 3.3
Choose a base branch
from

Conversation

suncairong163
Copy link
Contributor

What is the purpose of the change

add rest client tls

Brief changelog

Verifying this change

@AlbumenJ

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #12251 (1e7a1c6) into 3.3 (59758f4) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #12251      +/-   ##
============================================
- Coverage     68.40%   68.18%   -0.22%     
  Complexity        5        5              
============================================
  Files          1636     1648      +12     
  Lines         67469    68030     +561     
  Branches       9835     9895      +60     
============================================
+ Hits          46152    46387     +235     
- Misses        16849    17133     +284     
- Partials       4468     4510      +42     

see 64 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.3 May 23, 2023 12:03

import static org.apache.dubbo.common.constants.LoggerCodeConstants.TRANSPORT_FAILED_CLOSE_STREAM;

public class JDKSSLUtils {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class JDKSSLUtils {
public class JdkSslUtils {

import java.io.OutputStream;
import java.io.PushbackInputStream;

public class BASE64Decoder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java.util.Base64 is enough?

@sonarcloud
Copy link

sonarcloud bot commented May 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 57 Code Smells

30.3% 30.3% Coverage
2.4% 2.4% Duplication

Comment on lines +72 to +79

public boolean isPem() {
return isPem;
}

public void setPem(boolean pem) {
isPem = pem;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to match from context with regex?

@AlbumenJ
Copy link
Member

AlbumenJ commented Jun 1, 2023

@CrazyHZM @EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Add more ut & it is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants