Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ServiceInstancesChangedListener equals and hashcode method #12547

Merged
merged 5 commits into from Jul 13, 2023

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

The uniqueness of ServiceInstancesChangedListener should not be determined by listeners, because listeners is variable object, the same ServiceInstancesChangedListener object will be repeatedly added to the listener list, just use provider appname.

Brief changelog

Verifying this change

before:
image
after:
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #12547 (a682acb) into 3.2 (2c82cf7) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12547      +/-   ##
============================================
- Coverage     69.73%   69.36%   -0.38%     
+ Complexity      318        2     -316     
============================================
  Files          3481     1629    -1852     
  Lines        164990    67327   -97663     
  Branches      27746     9880   -17866     
============================================
- Hits         115061    46699   -68362     
+ Misses        39959    16107   -23852     
+ Partials       9970     4521    -5449     

see 1883 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@finefuture finefuture requested a review from AlbumenJ June 26, 2023 06:08
@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 3, 2023

@chickenlj PTAL

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 3, 2023

@CrazyHZM

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 78ca5e5 into apache:3.2 Jul 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants