Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson generic call returns a JSON string by default #12633

Merged
merged 3 commits into from Jul 11, 2023

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

  1. GsonUtils provide toJson method, use same json util to write json
  2. Gson generic call returns a JSON string by default

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.3 July 3, 2023 08:04
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This is a breaking change and I have changed it to 3.3 branch.

@codecov-commenter
Copy link

Codecov Report

Merging #12633 (27993db) into 3.3 (48cc5b2) will increase coverage by 1.21%.
The diff coverage is n/a.

❗ Current head 27993db differs from pull request most recent head 2f21b6f. Consider uploading reports for the commit 2f21b6f to get more accurate results

@@             Coverage Diff              @@
##                3.3   #12633      +/-   ##
============================================
+ Coverage     68.19%   69.41%   +1.21%     
+ Complexity        6        2       -4     
============================================
  Files          1675     1629      -46     
  Lines         68928    67408    -1520     
  Branches      10039     9888     -151     
============================================
- Hits          47007    46791     -216     
+ Misses        17337    16100    -1237     
+ Partials       4584     4517      -67     

see 249 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 16 Code Smells

26.7% 26.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlbumenJ AlbumenJ merged commit 8bb17b8 into apache:3.3 Jul 11, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants