Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random id #12663

Merged
merged 2 commits into from Jul 6, 2023
Merged

Use random id #12663

merged 2 commits into from Jul 6, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 4, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.1 July 6, 2023 00:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov-commenter
Copy link

Codecov Report

Merging #12663 (8c41c7d) into 3.1 (54238c2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #12663      +/-   ##
============================================
- Coverage     64.90%   64.90%   -0.01%     
  Complexity       14       14              
============================================
  Files          1433     1433              
  Lines         60130    60130              
  Branches       8857     8857              
============================================
- Hits          39028    39027       -1     
- Misses        17009    17012       +3     
+ Partials       4093     4091       -2     
Impacted Files Coverage Δ
...va/org/apache/dubbo/remoting/exchange/Request.java 92.59% <100.00%> (ø)

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit f882cbd into apache:3.1 Jul 6, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants