Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for running dubbo as a native image with nacos as the registry centre. #13246

Merged
merged 4 commits into from Oct 26, 2023

Conversation

chaicho
Copy link

@chaicho chaicho commented Oct 22, 2023

What is the purpose of the change

When trying to run a dubbo native application using nacos as the registry centre, the native image cannot run successfully since the reflection metadata of nacos is missing. This pr adds support for running native image when using nacos as the registry centre.

Brief changelog

Use the tracing agent to capture the reflection metadata required by a dubbo project using nacos as a registry centre. Add the reflection metadata to dubbo-nacos-registry to help dubbo users run their images successfully.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Merging #13246 (e3fd17a) into 3.3 (c98c487) will decrease coverage by 0.41%.
Report is 2 commits behind head on 3.3.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #13246      +/-   ##
============================================
- Coverage     68.41%   68.00%   -0.41%     
  Complexity        8        8              
============================================
  Files          1718     1727       +9     
  Lines         70833    71282     +449     
  Branches      10238    10292      +54     
============================================
+ Hits          48460    48478      +18     
- Misses        17683    18110     +427     
- Partials       4690     4694       +4     

see 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…r the private ones. Remove some unnecessary configs.
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 9681515 into apache:3.3 Oct 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants