Added scheduler closure check during RegistryNotifier notify. #13273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm seeing a CI error that says: "TEST FAILURE: case config not found: /home/runner/work/dubbo/dubbo/1-basic/dubbo-samples-spring-xml/case-configuration.yml," but I haven't made any changes to the relevant logic. Why did this CI error occur? |
AlbumenJ
requested changes
Nov 1, 2023
| if (delay) { | ||
| // when the scheduler is shutdown, no notification is sent | ||
| if (scheduler.isShutdown()) { | ||
| return; |
There was a problem hiding this comment.
Seems we shoud log something here.
Codecov Report
@@ Coverage Diff @@
## 3.2 #13273 +/- ##
============================================
- Coverage 69.49% 69.43% -0.06%
Complexity 2 2
============================================
Files 1653 1652 -1
Lines 68942 68961 +19
Branches 10048 10058 +10
============================================
- Hits 47911 47885 -26
- Misses 16392 16420 +28
- Partials 4639 4656 +17 see 63 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
AlbumenJ
requested changes
Nov 4, 2023
| // when the scheduler is shutdown, no notification is sent | ||
| if (scheduler.isShutdown()) { | ||
| if (logger.isWarnEnabled()) { | ||
| logger.warn(COMMON_FAILED_NOTIFY_EVENT, "", "", "Notification scheduler is off, no notifications are sent."); |
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
alibaba/nacos#11294
Brief changelog
Verifying this change
Checklist