Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DubboAutoConfiguration can not be processed AOT in spring native image scenario #13461

Merged
merged 1 commit into from Dec 13, 2023

Conversation

FoghostCn
Copy link
Contributor

fix #13434

fix DubboAutoConfiguration and DubboRelaxedBinding2AutoConfiguration init too early,
can not be processed AOT in spring native image scenario

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@FoghostCn FoghostCn marked this pull request as draft December 5, 2023 11:21
@FoghostCn FoghostCn marked this pull request as ready for review December 5, 2023 11:27
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CrazyHZM PTAL

…init too early,

can not be processed AOT in spring native image scenario
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f48269) 40.43% compared to head (97a9ee3) 40.39%.
Report is 39 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13461      +/-   ##
==========================================
- Coverage   40.43%   40.39%   -0.04%     
==========================================
  Files        1808     1806       -2     
  Lines       75893    75888       -5     
  Branches    10642    10644       +2     
==========================================
- Hits        30687    30656      -31     
- Misses      40886    40925      +39     
+ Partials     4320     4307      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit ad803e1 into apache:3.3 Dec 13, 2023
13 checks passed
@FoghostCn FoghostCn deleted the 3.3 branch December 13, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants