Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:DubboService annotation support custom serialization #13553

Merged
merged 9 commits into from Dec 27, 2023

Conversation

zhaoyunxing92
Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 commented Dec 21, 2023

What is the purpose of the change

fix: #13552

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

config.getScopeModel(),
Serialization.class,
PREFER_SERIALIZATION_KEY,
config.getPreferSerialization());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of prefer.serialization should be splitted first cause it can be fastjson2,hessian2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfigValidationUtils.java#L695 value has been splitted

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb8d7a3) 70.35% compared to head (69c8035) 70.38%.
Report is 21 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13553      +/-   ##
==========================================
+ Coverage   70.35%   70.38%   +0.03%     
==========================================
  Files        1603     1605       +2     
  Lines       69886    69970      +84     
  Branches    10092    10092              
==========================================
+ Hits        49165    49247      +82     
+ Misses      16096    16087       -9     
- Partials     4625     4636      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 27, 2023

@AlbumenJ AlbumenJ added this to the 3.2.11 milestone Dec 27, 2023
@AlbumenJ AlbumenJ merged commit 25b73b1 into apache:3.2 Dec 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DubboService annotation support custom serialization
3 participants