Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obtaining remote application name on the server side #13811

Merged
merged 5 commits into from Mar 8, 2024

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

  1. Fix obtaining remote application name on the server side
  2. Use enum instead of hardcode

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.93%. Comparing base (b14e5e3) to head (bbec796).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13811      +/-   ##
==========================================
+ Coverage   38.91%   38.93%   +0.01%     
==========================================
  Files        1897     1897              
  Lines       79317    79321       +4     
  Branches    11529    11530       +1     
==========================================
+ Hits        30866    30880      +14     
+ Misses      44132    44125       -7     
+ Partials     4319     4316       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@finefuture
Copy link
Contributor Author

For example:
image

It should be handled in the same way as grpc-timeout, like this:
image

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Mar 7, 2024

@AlbumenJ AlbumenJ merged commit cb92fcc into apache:3.3 Mar 8, 2024
19 checks passed
@@ -119,6 +120,11 @@ protected RpcInvocation onBuildRpcInvocationCompletion(RpcInvocation invocation)
getContext().getServiceDescriptor().getInterfaceName(),
getContext().getMethodName()));
}
String consumerAppKey =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add it in org.apache.dubbo.rpc.protocol.tri.h12.AbstractServerTransportListener#buildRpcInvocation
I think not only grpc need the consumerAppName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants