-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spring related transitive dependencies from dubbo-all #14137
base: 3.3
Are you sure you want to change the base?
Conversation
chickenlj
commented
Apr 28, 2024
- spring xml related samples need to be adjusted to meet this change
- documentation needs to be updated for non spring-boot users
- spring-boot users would not be affected, but with dependency conflict chances reduced
|
I am now working on it.
As triple going to become the major protocol of Dubbo framework in the next release, I think we should have it by default, just like what we do with hessian2 before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to remove spring dependencies from dubbo-all.
Dubbo is used in three ways:
- dubbo API (without spring)
- dubbo + dubbo-config-spring (without SpringBoot)
- dubbo + SpringBoot (dubbo-spring-boot-starter)
Quality Gate passedIssues Measures |
It's ready to merge |
<dependency> | ||
<groupId>com.google.protobuf</groupId> | ||
<artifactId>protobuf-java</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.protobuf</groupId> | ||
<artifactId>protobuf-java-util</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need some discussion about we add these dependencies or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, remember to bring it up on the next weekly meeting.