Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Exclude transitive spring dependencies from dubbo-all or dubbo-spring-boot-starter #14032

Open
3 of 4 tasks
chickenlj opened this issue Apr 5, 2024 · 6 comments
Assignees
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@chickenlj
Copy link
Contributor

chickenlj commented Apr 5, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

3.3.0-beta.2

Steps to reproduce this issue

Remove the following transitive dependencies from dubbo-all, if not possible, at least exclude them in dubbo-spring-boot-starter.

  <!-- Transitive dependencies -->
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-core</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-beans</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-context</artifactId>
    </dependency>

Try to completely get rid of the following dependency:

    <dependency>
      <groupId>com.alibaba.spring</groupId>
      <artifactId>spring-context-support</artifactId>
    </dependency>

What you expected to happen

  • When using spring, the recommended way is spring boot, so transitive spring dependencies is not necessary, let spring-boot-starter do this for users.
  • When using API, we don't need spring dependencies.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@chickenlj chickenlj added type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage labels Apr 5, 2024
@heliang666s
Copy link
Contributor

hello,I think I can do it,please assign me,thanks~

@AlbumenJ
Copy link
Member

AlbumenJ commented Apr 7, 2024

hello,I think I can do it,please assign me,thanks~

done

@heliang666s
Copy link
Contributor

@AlbumenJ You seem to be getting people wrong

@chickenlj chickenlj assigned heliang666s and unassigned chickenlj Apr 8, 2024
@AlbumenJ
Copy link
Member

AlbumenJ commented Apr 8, 2024

@AlbumenJ You seem to be getting people wrong

My fault😭

@fastkdm
Copy link

fastkdm commented Jun 20, 2024

transitive dependencies exists 3.3.0-Beta.3

@wcy666103
Copy link
Contributor

wcy666103 commented Jun 21, 2024

transitive dependencies exists 3.3.0-Beta.3

Yes, it hasn't been merged yet, details are here #14137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

5 participants