fix #3069 #3075
Closed
fix #3069 #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicate: #3076 |
6 tasks
…orListener. * refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * avoid dup code in init * add fixme for potential useless code
…/dubbo-registry-default (apache#3053) * add FailedRetryTaskTest.java
…view. * refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * avoid dup code in init * add fixme for potential useless code * clean up useless variables * move methods into UrlUtils * make method private * reformat javadoc * avoid dup code * reformat log message * reformat log message * reformat the code * remove useless imports * remove useless code * refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * Add comment * Fix UT * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * Revert demo changes * Revert code to avoid NPE in RPC wire after providers are cleared. * make ListenableRouter code thread safe * Fix UT * Remove assert check to continue with execute. * avoid dup code in init * solve compile error * add fixme for potential useless code * clean up useless variables * move methods into UrlUtils * make method private * reformat javadoc * avoid dup code * reformat log message * reformat log message * reformat the code * remove useless imports * remove useless code * code review comments from @khanimteyaz * code review from @khanimteyaz
|
This submission is too messy, I resubmit a pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
return null if input String is null or ""
Add test cases to this method.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.