Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event of response fix#3244 #3247

Merged
merged 2 commits into from
Feb 2, 2019
Merged

event of response fix#3244 #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e46f89
event of response fix#3244
CrazyHZM Jan 16, 2019
02b58ec
Merge branch 'master' into eventOfRrsponse
CrazyHZM Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...emoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/Response.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ public void setEvent(String event) {
mResult = event;
}

public void setEvent(boolean mEvent) {
this.mEvent = mEvent;
}

public boolean isHeartbeat() {
return mEvent && HEARTBEAT_EVENT == mResult;
}
Expand Down
2 changes: 1 addition & 1 deletion ...bo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/codec/ExchangeCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ protected Object decodeBody(Channel channel, InputStream is, byte[] header) thro
// decode response.
Response res = new Response(id);
if ((flag & FLAG_EVENT) != 0) {
res.setEvent(Response.HEARTBEAT_EVENT);
res.setEvent(true);
}
// get status.
byte status = header[3];
Expand Down
2 changes: 1 addition & 1 deletion ...-api/src/test/java/org/apache/dubbo/remoting/transport/codec/DeprecatedExchangeCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ protected Object decodeBody(Channel channel, InputStream is, byte[] header) thro
// decode response.
Response res = new Response(id);
if ((flag & FLAG_EVENT) != 0) {
res.setEvent(Response.HEARTBEAT_EVENT);
res.setEvent(true);
}
// get status.
byte status = header[3];
Expand Down
2 changes: 1 addition & 1 deletion dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected Object decodeBody(Channel channel, InputStream is, byte[] header) thro
// decode response.
Response res = new Response(id);
if ((flag & FLAG_EVENT) != 0) {
res.setEvent(Response.HEARTBEAT_EVENT);
res.setEvent(true);
}
// get status.
byte status = header[3];
Expand Down