Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify config config items: qos.enable to qos-enable. #4095

Merged
merged 3 commits into from
May 24, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

fixes #3958

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj requested a review from mercyblitz May 20, 2019 05:32
@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #4095 into master will increase coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4095      +/-   ##
============================================
+ Coverage     62.66%   62.77%   +0.11%     
- Complexity      473      474       +1     
============================================
  Files           763      766       +3     
  Lines         32845    32897      +52     
  Branches       5182     5189       +7     
============================================
+ Hits          20582    20652      +70     
+ Misses         9894     9858      -36     
- Partials       2369     2387      +18
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/ApplicationConfig.java 91.3% <33.33%> (-6.29%) 0 <0> (ø)
...ubbo/metadata/store/redis/RedisMetadataReport.java 52.94% <0%> (-47.06%) 6% <0%> (+1%)
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 60% <0%> (-23.34%) 0% <0%> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 76.19% <0%> (-10.48%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 56% <0%> (-8.52%) 0% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 63.73% <0%> (-6.6%) 0% <0%> (ø)
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 28.57% <0%> (-4.77%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...rg/apache/dubbo/monitor/support/MonitorFilter.java 71.42% <0%> (-4.44%) 0% <0%> (ø)
.../org/apache/dubbo/config/MetadataReportConfig.java 88.09% <0%> (-4.22%) 0% <0%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f56a3...faec7b5. Read the comment docs.

@Moriadry-zz
Copy link

There are some conflicts in your pr.

Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mercyblitz have reviewed this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Qos port can't be disabled by externalized property
4 participants