New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-4299]Fix NPE when PojoUtils realize Null element in collection(#4299) #4300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide unit tests
done |
Codecov Report
@@ Coverage Diff @@
## master #4300 +/- ##
============================================
- Coverage 62.94% 62.92% -0.02%
+ Complexity 506 504 -2
============================================
Files 769 769
Lines 33041 33041
Branches 5215 5216 +1
============================================
- Hits 20798 20792 -6
- Misses 9850 9853 +3
- Partials 2393 2396 +3
Continue to review full report at Codecov.
|
…pache#4299) (apache#4300) * fix NPE when PojoUtils realize Null element in collection(apache#4299) * add unit tests for bugfix of PojoUtils NPE(apache#4299) * revert import (apache#4299)
…pache#4299) (apache#4300) * fix NPE when PojoUtils realize Null element in collection(apache#4299) * add unit tests for bugfix of PojoUtils NPE(apache#4299) * revert import (apache#4299)
What is the purpose of the change
https://github.com/apache/dubbo/issues/4299
Brief changelog
Fix NPE when PojoUtils realize Null element in collection
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.