Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4299]Fix NPE when PojoUtils realize Null element in collection(#4299) #4300

Merged
merged 3 commits into from Jun 24, 2019
Merged

[Dubbo-4299]Fix NPE when PojoUtils realize Null element in collection(#4299) #4300

merged 3 commits into from Jun 24, 2019

Conversation

HzjNeverStop
Copy link
Contributor

What is the purpose of the change

https://github.com/apache/dubbo/issues/4299

Brief changelog

Fix NPE when PojoUtils realize Null element in collection

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor Author

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Member

@zonghaishang zonghaishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide unit tests

@HzjNeverStop
Copy link
Contributor Author

Please provide unit tests

done

@codecov-io
Copy link

Codecov Report

Merging #4300 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4300      +/-   ##
============================================
- Coverage     62.94%   62.92%   -0.02%     
+ Complexity      506      504       -2     
============================================
  Files           769      769              
  Lines         33041    33041              
  Branches       5215     5216       +1     
============================================
- Hits          20798    20792       -6     
- Misses         9850     9853       +3     
- Partials       2393     2396       +3
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/common/utils/PojoUtils.java 72.07% <100%> (+0.56%) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-2.18%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-1.41%) 20% <0%> (-2%)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <0%> (-0.67%) 27% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acf5b8...cba5d34. Read the comment docs.

@zonghaishang zonghaishang merged commit 7285ce9 into apache:master Jun 24, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…pache#4299) (apache#4300)

* fix NPE when PojoUtils realize Null element in collection(apache#4299)

* add unit tests for bugfix of PojoUtils NPE(apache#4299)

* revert import (apache#4299)
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…pache#4299) (apache#4300)

* fix NPE when PojoUtils realize Null element in collection(apache#4299)

* add unit tests for bugfix of PojoUtils NPE(apache#4299)

* revert import (apache#4299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants