Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug about nacos #4308

Merged
merged 2 commits into from Jun 27, 2019
Merged

fix bug about nacos #4308

merged 2 commits into from Jun 27, 2019

Conversation

IanCao
Copy link
Contributor

@IanCao IanCao commented Jun 14, 2019

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@IanCao
Copy link
Contributor Author

IanCao commented Jun 14, 2019

alibaba/nacos#1364

@codecov-io
Copy link

Codecov Report

Merging #4308 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4308      +/-   ##
============================================
- Coverage     62.88%   62.86%   -0.02%     
+ Complexity      506      503       -3     
============================================
  Files           769      769              
  Lines         32995    32995              
  Branches       5215     5215              
============================================
- Hits          20749    20743       -6     
- Misses         9844     9847       +3     
- Partials       2402     2405       +3
Impacted Files Coverage Δ Complexity Δ
...che/dubbo/registry/nacos/NacosRegistryFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-1.41%) 20% <0%> (-2%)
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.68% <0%> (+1.8%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3a05c...16bd49e. Read the comment docs.

Copy link
Contributor

@andyqian andyqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry

Copy link
Contributor

@andyqian andyqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing

@htynkn htynkn added this to the 2.7.3 milestone Jun 20, 2019
@htynkn
Copy link
Member

htynkn commented Jun 20, 2019

Use StringUtils in nacos client is not right, but I still it's good to use util in dubbo common, refer to

public static boolean isEmpty(String str) {

Or util in org.apache.commons.lang3

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 024651d into apache:master Jun 27, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants