Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate decrease for ExecuteLimitFilter onError #4380

Merged
merged 1 commit into from Jun 27, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Related to #4276

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4380 into 2.7.3-release will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.3-release    #4380      +/-   ##
===================================================
- Coverage            62.87%   62.85%   -0.02%     
+ Complexity             505      502       -3     
===================================================
  Files                  769      769              
  Lines                32995    33007      +12     
  Branches              5215     5219       +4     
===================================================
+ Hits                 20746    20747       +1     
- Misses                9844     9850       +6     
- Partials              2405     2410       +5
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/apache/dubbo/rpc/RpcException.java 83.33% <0%> (+0.57%) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88% <42.85%> (-7.46%) 0 <0> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 69.23% <50%> (-6.96%) 0 <0> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 54.11% <0%> (-8.24%) 19% <0%> (-2%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 65.09% <0%> (-1.89%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.29%) 31% <0%> (-1%)
...he/dubbo/registry/multicast/MulticastRegistry.java 69.23% <0%> (+1.35%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (+1.53%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa52b2...55d70e1. Read the comment docs.

@@ -106,4 +109,8 @@ public boolean isSerialization() {
public boolean isNoInvokerAvailableAfterFilter() {
return code == NO_INVOKER_AVAILABLE_AFTER_FILTER;
}

public boolean isLimitExceed() {
return code == LIMIT_EXCEEDED_EXCEPTION || getCause() instanceof LimitExceededException;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面这个类型检测要来干嘛?

@chickenlj chickenlj deleted the activelimitefilter-4276 branch September 3, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants