Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo-4491]remove duplicate code in AbstractConfig.java #4492

Merged
merged 3 commits into from
Jul 11, 2019

Conversation

zhenxianyimeng
Copy link
Contributor

What is the purpose of the change

remove duplicate code in AbstractConfig.java to make brief and clean

Brief changelog

remove code ClassUtils.isPrimitive(method1.getReturnType()) in AbstractConfig.java at line 653

Verifying this change

ClassUtils.isPrimitive(method1.getReturnType()) is already judge in method MethodUtils.isGetter

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@zhenxianyimeng
Copy link
Contributor Author

why ci build is always pending, i see it have been passed in
https://travis-ci.org/apache/dubbo/builds/555817384?utm_source=github_status&utm_medium=notification

@htynkn htynkn self-requested a review July 11, 2019 09:36
@htynkn
Copy link
Member

htynkn commented Jul 11, 2019

ClassUtils.isPrimitive is called

&& ClassUtils.isPrimitive(method.getReturnType());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants