Merge exceptions, remove redundant interface implementations #4730
Conversation
| final TServer thriftServer = new TThreadedSelectorServer(tArgs); | ||
| serverMap.put(url.getAddress(),thriftServer); | ||
| final TServer thriftServer = new TThreadedSelectorServer(tArgs); | ||
| serverMap.put(url.getAddress(), thriftServer); |
There was a problem hiding this comment.
Do we have a method(such as a pattern?) to make all those formatter done? I found many this kind of problems.
Like
There was a problem hiding this comment.
Different protocols have different implementations, and I don't think there is a need to use design patterns here.
There was a problem hiding this comment.
I mean the lack of space here, not design pattern, but code format.
There was a problem hiding this comment.
Sorry, understand the mistake, modify it later.
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
============================================
- Coverage 59.22% 59.11% -0.11%
- Complexity 503 527 +24
============================================
Files 1076 1076
Lines 43410 43410
Branches 6339 6340 +1
============================================
- Hits 25709 25662 -47
- Misses 14858 14906 +48
+ Partials 2843 2842 -1
Continue to review full report at Codecov.
|
|
|
# Conflicts: # dubbo-rpc/dubbo-rpc-native-thrift/src/main/java/org/apache/dubbo/rpc/protocol/nativethrift/ThriftProtocol.java
|
@CrazyHZM Hi, pls resolve conficts. |
# Conflicts: # dubbo-rpc/dubbo-rpc-native-thrift/src/main/java/org/apache/dubbo/rpc/protocol/nativethrift/ThriftProtocol.java
|
@AlbumenJ done |
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.