Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw exception when data bind from properties file encounter error #4757

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

tswstarplanet
Copy link
Contributor

What is the purpose of the change

When there are errors in properties file and data bind encounter error, dubbo now will not throw exception but ignore the errors.
The errors should be thrown to users.

Brief changelog

DefaultDubboConfigBinder.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4757 into master will increase coverage by 0.06%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4757      +/-   ##
===========================================
+ Coverage     63.84%   63.9%   +0.06%     
- Complexity      450     451       +1     
===========================================
  Files           769     769              
  Lines         33144   33192      +48     
  Branches       5203    5232      +29     
===========================================
+ Hits          21160   21212      +52     
+ Misses         9562    9558       -4     
  Partials       2422    2422
Impacted Files Coverage Δ Complexity Δ
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <7.69%> (-57.15%) 0 <0> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...ing/zookeeper/support/AbstractZookeeperClient.java 66.66% <0%> (-3.71%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-2%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/qos/textui/TTable.java 83.79% <0%> (-0.87%) 0% <0%> (ø)
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 66.66% <0%> (-0.71%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.26%) 31% <0%> (ø)
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 78.04% <0%> (-0.2%) 0% <0%> (ø)
...mon/src/main/java/org/apache/dubbo/common/URL.java 50.22% <0%> (-0.08%) 0% <0%> (ø)
...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56eaa8...f2a923d. Read the comment docs.

@CodingSinger
Copy link
Member

LGTM

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2019

CLA assistant check
All committers have signed the CLA.

@AlbumenJ AlbumenJ merged commit ced9103 into apache:master Apr 11, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants