[Dubbo-5125] 修复provider在网络波动恢复后，无法正确恢复在zookeeper的注册信息 #5125 #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Also see #5135 |
chickenlj
reviewed
Oct 8, 2019
Comment on lines
+113
to
121
| try { | ||
| if (!checkEphemeralBelongToCurrentSession(path)) { | ||
| deletePath(path); | ||
| createEphemeral(path); | ||
| } | ||
| }catch (Exception e1) { | ||
| throw new IllegalStateException(e.getMessage(), e1); | ||
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
I find this method will get triggered whenever ConnectionState.RECONNECT happens, which can be caused on the root by either connection recover or new session creation. I think it would be better if we can recognize this different condition by checking session id at the entry point of the callback.
There was a problem hiding this comment.
I agree with you that it is better to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #5125
Verifying this change
createEphemeral 捕获到 NodeExistsException 时，判断Ephemeral 节点是否属于当前会话，若不属于，则删除重建此Ephemeral节点