Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix re-register can not work when curator session expires. #5135

Merged
merged 4 commits into from
Oct 12, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

related #5126

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #5135 into 2.7.4-release will decrease coverage by 0.03%.
The diff coverage is 45.45%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.4-release    #5135      +/-   ##
===================================================
- Coverage            64.08%   64.05%   -0.04%     
  Complexity             452      452              
===================================================
  Files                  769      769              
  Lines                33240    33300      +60     
  Branches              5240     5251      +11     
===================================================
+ Hits                 21302    21329      +27     
- Misses                9508     9537      +29     
- Partials              2430     2434       +4
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/registry/support/FailbackRegistry.java 74.28% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 70.58% <0%> (-1.01%) 0 <0> (ø)
...ing/zookeeper/support/AbstractZookeeperClient.java 70.32% <100%> (+0.66%) 0 <0> (ø) ⬇️
...ookeeper/support/AbstractZookeeperTransporter.java 67.5% <100%> (-17.5%) 0 <0> (ø)
...ting/zookeeper/curator/CuratorZookeeperClient.java 64.21% <61.22%> (+0.63%) 0 <0> (ø) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 58.75% <9.52%> (-8.63%) 0 <0> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-6.53%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d65897...9605502. Read the comment docs.

1. Ignore connection event in children watcher.
2. Fetch latest urls after connection recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants