-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix re-register can not work when curator session expires. #5135
Merged
cvictory
merged 4 commits into
apache:2.7.4-release
from
chickenlj:curator-session-expire
Oct 12, 2019
Merged
fix re-register can not work when curator session expires. #5135
cvictory
merged 4 commits into
apache:2.7.4-release
from
chickenlj:curator-session-expire
Oct 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.7.4-release #5135 +/- ##
===================================================
- Coverage 64.08% 64.05% -0.04%
Complexity 452 452
===================================================
Files 769 769
Lines 33240 33300 +60
Branches 5240 5251 +11
===================================================
+ Hits 21302 21329 +27
- Misses 9508 9537 +29
- Partials 2430 2434 +4
Continue to review full report at Codecov.
|
lt964709769
reviewed
Oct 8, 2019
...keeper/src/main/java/org/apache/dubbo/remoting/zookeeper/curator/CuratorZookeeperClient.java
Show resolved
Hide resolved
1. Ignore connection event in children watcher. 2. Fetch latest urls after connection recovery.
cvictory
reviewed
Oct 12, 2019
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/Constants.java
Outdated
Show resolved
Hide resolved
cvictory
reviewed
Oct 12, 2019
...-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
related #5126