Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#5411 #5427

Merged
merged 1 commit into from Dec 9, 2019
Merged

Fix issue#5411 #5427

merged 1 commit into from Dec 9, 2019

Conversation

zhaixiaoxiang
Copy link
Contributor

What is the purpose of the change

Fix issue #5411

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #5427 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5427      +/-   ##
============================================
+ Coverage      61.2%   61.26%   +0.05%     
+ Complexity      424      423       -1     
============================================
  Files           919      919              
  Lines         37489    37492       +3     
  Branches       5461     5462       +1     
============================================
+ Hits          22945    22968      +23     
+ Misses        12041    12021      -20     
  Partials       2503     2503
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/config/AbstractReferenceConfig.java 86.79% <ø> (-0.25%) 0 <0> (ø)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 58.24% <ø> (+1.54%) 0 <0> (ø) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 84.65% <100%> (+0.87%) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
...va/org/apache/dubbo/common/utils/ReflectUtils.java 70.39% <0%> (+0.35%) 0% <0%> (ø) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 64.6% <0%> (+2.65%) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083748d...b546498. Read the comment docs.

@@ -179,13 +179,17 @@ public void addProviders(Iterable<ProviderConfig> providerConfigs) {
}

public Optional<ProviderConfig> getDefaultProvider() {
return getProvider(DEFAULT_KEY);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@chickenlj chickenlj merged commit 4704413 into apache:master Dec 9, 2019
chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants