Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish getUrl and getConsumerUrl from Directory. #5775

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

chickenlj
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #5775 into master will decrease coverage by 0.02%.
The diff coverage is 52.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5775      +/-   ##
============================================
- Coverage     61.35%   61.33%   -0.03%     
- Complexity      496      497       +1     
============================================
  Files           979      979              
  Lines         38876    38893      +17     
  Branches       5603     5606       +3     
============================================
+ Hits          23854    23856       +2     
- Misses        12399    12410      +11     
- Partials       2623     2627       +4
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/rpc/model/ServiceDescriptor.java 91.17% <ø> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <ø> (ø) 9 <0> (ø) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 66.03% <ø> (ø) 0 <0> (ø) ⬇️
...pc/cluster/support/wrapper/MockClusterInvoker.java 66.12% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/config/spring/util/DubboBeanUtils.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...nfig/bootstrap/builders/MetadataReportBuilder.java 97.36% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java 23.1% <ø> (ø) 0 <0> (ø) ⬇️
.../metadata/store/RemoteWritableMetadataService.java 77.31% <ø> (ø) 0 <0> (ø) ⬇️
...gistry/client/EventPublishingServiceDiscovery.java 74.35% <ø> (ø) 0 <0> (ø) ⬇️
...common/serialize/hessian2/Hessian2ObjectInput.java 94.11% <0%> (-5.89%) 0 <0> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8deb462...10d57bc. Read the comment docs.

# Conflicts:
#	dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
@qinliujie
Copy link
Contributor

LGTM

@qinliujie qinliujie merged commit 048fadf into apache:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants