Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a redundant judgment code #5909

Merged
merged 1 commit into from Apr 1, 2020

Conversation

xulingfeng931027
Copy link
Contributor

What is the purpose of the change

去掉代码里多余的一次判断

Brief changelog

第一次进入for循环的时候会进入 if (leastActive == -1 || active < leastActive) 里面 因为leastActive 初始值为-1 , 进入else if (active == leastActive)逻辑时上面for循环的i肯定是大于0的,因此无需判断i>0了.

Verifying this change

原有的单元逻辑都能通过.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@xulingfeng931027
Copy link
Contributor Author

So the first time you go into the for loop you're going to go into the if (leastActive == -1 || active < leastActive) because leastActive starts at negative 1, and then if you go into the else if (active == leastActive) logic the I of the for loop is definitely greater than 0, so you don't have to say I >0.

@chickenlj chickenlj merged commit 5312f5f into apache:master Apr 1, 2020
xulingfeng931027 added a commit to xulingfeng931027/dubbo that referenced this pull request Apr 1, 2020
Codeprh added a commit to Codeprh/dubbo-go that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants