Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new class (InternalRunnable) is added to wrap the ordinary Runnable… #6141

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

KArthurL
Copy link

@KArthurL KArthurL commented May 12, 2020

What is the purpose of the change

If subsequent internal components need to use InternalThreadLocal, improper use still has the risk of memory leaks. Using InternalRunnable to wrap ordinary Runnable can automatically clean up the InternalThreadLocal variable of the current thread after the task is completed.

Brief changelog

dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/InternalRunnable.java
dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/NamedInternalThreadFactory.java

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…, which implements automatic cleaning of InternalThreadLocal
…, which implements automatic cleaning of InternalThreadLocal
…, which implements automatic cleaning of InternalThreadLocal
…, which implements automatic cleaning of InternalThreadLocal
…, which implements automatic cleaning of InternalThreadLocal
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Feb 23, 2021
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 6db0dc1 into apache:master Feb 23, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants