Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6177] PojoUtils realize not correct for Multidimensional primi… #6178

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

sqtds
Copy link

@sqtds sqtds commented May 18, 2020

…tive array #6177

What is the purpose of the change

support Multidimensional primitive array

Brief changelog

modify ReflectUtils.isPrimitives method

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@sqtds sqtds changed the title [Dubbo-6177] PojoUtils realize not current for Multidimensional primi… [Dubbo-6177] PojoUtils realize not correct for Multidimensional primi… May 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #6178 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6178      +/-   ##
============================================
- Coverage     60.90%   60.86%   -0.05%     
  Complexity      494      494              
============================================
  Files           999      999              
  Lines         39898    39898              
  Branches       5744     5744              
============================================
- Hits          24301    24282      -19     
- Misses        12907    12924      +17     
- Partials       2690     2692       +2     
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/common/utils/ReflectUtils.java 69.38% <100.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 52.36% <0.00%> (-0.57%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.10% <0.00%> (-0.35%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2f6af...8954480. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ
Copy link
Member

fix #6177

@AlbumenJ AlbumenJ merged commit 23e38e4 into apache:master Feb 23, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants