Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keepalive parameters configurable on server #6500

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

skyguard1
Copy link
Contributor

@skyguard1 skyguard1 commented Jul 21, 2020

What is the purpose of the change

Currently dubbo.protocol.keepAlive does not work on the server side. The purpose of this commit is to use this parameter as a configurable parameter. Please review this pr, thank you

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ added the status/waiting-for-feedback Need reporters to triage label Mar 14, 2021
@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Mar 17, 2021
@AlbumenJ AlbumenJ merged commit 28e2f3b into apache:master Mar 17, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants