Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-2.7.8]Fix DynamicConfiguration namespace property read bug when use custom namespace #6717

Merged
merged 1 commit into from Feb 25, 2021

Conversation

furaul
Copy link

@furaul furaul commented Sep 9, 2020

Github issue

#6606

What is the purpose of the change

Fix ConfigCenter namespace read bug in apollo, etcd and so on.
修复apollo、etcd等配置中心读取namespace错误的bug。

Brief changelog

use org.apache.dubbo.common.constants.CommonConstants#CONFIG_NAMESPACE_KEY instead of org.apache.dubbo.common.config.configcenter.Constants#CONFIG_NAMESPACE_KEY.

在apollo、etcd等配置中心的实现中,使用org.apache.dubbo.common.constants.CommonConstants#CONFIG_NAMESPACE_KEY 来替换org.apache.dubbo.common.config.configcenter.Constants#CONFIG_NAMESPACE_KEY,确保自配置的配置中心namespace可以正确读取。

Verifying this change

All unit tests have passed.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

修复apollo、etcd等配置中心读取namespace错误的bug。
@furaul
Copy link
Author

furaul commented Sep 11, 2020

@beiwei30 @chickenlj

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlbumenJ AlbumenJ merged commit 04c70e5 into apache:master Feb 25, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants