Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OOM issue for Hessian2ObjectInput and Hessian2ObjectOutput #6848

Merged
merged 3 commits into from
Mar 14, 2021

Conversation

luckyyuandm
Copy link

@luckyyuandm luckyyuandm commented Oct 29, 2020

Change-Id: I4fce78be15179722fea1fa645495783c60b28573
Signed-off-by: yuandm yuandm@foxmail.com

What is the purpose of the change

fix OOM when deserializing data

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Change-Id: I4fce78be15179722fea1fa645495783c60b28573
Signed-off-by: yuandm <yuandm@foxmail.com>
@htynkn htynkn added the type/bug Bugs to being fixed label Oct 30, 2020
@kimmking kimmking dismissed their stale review October 30, 2020 16:54

should modify

Change-Id: Iadf99b0c72b621ef3b038d1324c6626e75dbfc8e
Signed-off-by: yuandm <yuandm@foxmail.com>
Change-Id: Ifa733d185b68f10a8fbf10e32d73089a32d0d312
Signed-off-by: yuandm <yuandm@foxmail.com>
@codecov-io
Copy link

Codecov Report

Merging #6848 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6848      +/-   ##
============================================
- Coverage     59.15%   59.12%   -0.04%     
+ Complexity      510      507       -3     
============================================
  Files          1028     1028              
  Lines         41534    41541       +7     
  Branches       6041     6041              
============================================
- Hits          24570    24560      -10     
- Misses        14194    14201       +7     
- Partials       2770     2780      +10     
Impacted Files Coverage Δ Complexity Δ
...common/serialize/hessian2/Hessian2ObjectInput.java 92.00% <66.66%> (-3.46%) 0.00 <0.00> (ø)
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 94.59% <66.66%> (-2.47%) 0.00 <0.00> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 38.46% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.25% <0.00%> (-1.86%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (-0.96%) 16.00% <0.00%> (-1.00%)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 53.17% <0.00%> (-0.58%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 66.21% <0.00%> (-0.35%) 0.00% <0.00%> (ø%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 42.03% <0.00%> (-0.17%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8da59...6552342. Read the comment docs.

@htynkn htynkn changed the title fix OOM fix OOM issue for Hessian2ObjectInput and Hessian2ObjectOutput Nov 6, 2020
@chickenlj chickenlj added this to the 2.7.9 milestone Nov 17, 2020
@chickenlj chickenlj modified the milestones: 2.7.9, 2.7.10 Feb 8, 2021
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit a02bd5d into apache:master Mar 14, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants