Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-AbstractConfig] Fix password be print in plain text #6931

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

FavorMylikes
Copy link

@FavorMylikes FavorMylikes commented Nov 20, 2020

What is the purpose of the change

Hidden the important password information to avoid be printed in plain text into the logger file

Brief changelog

Update AbstractConfig.java
hidden password

Verifying this change

The registry[<dubbo:registry password="******" username="someone" timeout="10000" group="test" client="curator" address="127.0.0.1" protocol="zookeeper" port="2181" />] will be used as the config center, dubbo version: 2.7.8, current host: 127.0.0.1

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Hidden the important password information to avoid be printed in plain text into the logger file
@FavorMylikes
Copy link
Author

Issue is here
#6930

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #6931 (f2c9c1f) into master (3fc2d10) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6931      +/-   ##
============================================
- Coverage     59.44%   59.26%   -0.18%     
+ Complexity      511      504       -7     
============================================
  Files          1028     1028              
  Lines         41519    41519              
  Branches       6037     6022      -15     
============================================
- Hits          24679    24605      -74     
- Misses        14104    14157      +53     
- Partials       2736     2757      +21     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/AbstractConfig.java 73.05% <0.00%> (-0.33%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-11.85%) 15.00% <0.00%> (-2.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-9.10%) 18.00% <0.00%> (-3.00%)
.../registry/multicast/MulticastServiceDiscovery.java 23.07% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 56.52% <0.00%> (-6.53%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 92.50% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...f2c9c1f. Read the comment docs.

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

change == to equals
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 1624b2d into apache:master Apr 12, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
@FavorMylikes FavorMylikes deleted the patch-1 branch July 7, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants