-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-AbstractConfig] Fix password be print in plain text #6931
Conversation
Hidden the important password information to avoid be printed in plain text into the logger file
Issue is here |
Codecov Report
@@ Coverage Diff @@
## master #6931 +/- ##
============================================
- Coverage 59.44% 59.26% -0.18%
+ Complexity 511 504 -7
============================================
Files 1028 1028
Lines 41519 41519
Branches 6037 6022 -15
============================================
- Hits 24679 24605 -74
- Misses 14104 14157 +53
- Partials 2736 2757 +21 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
change == to equals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Hidden the important password information to avoid be printed in plain text into the logger file
Brief changelog
Update AbstractConfig.java
hidden password
Verifying this change
The registry[<dubbo:registry password="******" username="someone" timeout="10000" group="test" client="curator" address="127.0.0.1" protocol="zookeeper" port="2181" />] will be used as the config center, dubbo version: 2.7.8, current host: 127.0.0.1
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.