Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#6999] Remove repeat action of register DubboBootstrapApplicationListener #7000

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

Fix-#6999

… ServiceClassPostProcessor, it already register in DubboApplicationListenerRegistrar
@codecov-io
Copy link

Codecov Report

Merging #7000 (62d8d70) into master (a2a14dc) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7000      +/-   ##
============================================
- Coverage     59.13%   59.03%   -0.11%     
+ Complexity      509      504       -5     
============================================
  Files          1028     1028              
  Lines         41519    41518       -1     
  Branches       6037     6021      -16     
============================================
- Hits          24554    24510      -44     
- Misses        14197    14227      +30     
- Partials       2768     2781      +13     
Impacted Files Coverage Δ Complexity Δ
.../factory/annotation/ServiceClassPostProcessor.java 83.89% <ø> (-0.11%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-9.10%) 18.00% <0.00%> (-3.00%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a14dc...62d8d70. Read the comment docs.

@horizonzy
Copy link
Member Author

@mercyblitz

@kylixs
Copy link
Member

kylixs commented Feb 22, 2021

LGTM

@chickenlj chickenlj merged commit f75c22c into apache:master Feb 22, 2021
@chickenlj chickenlj added this to the 2.7.10 milestone Feb 22, 2021
chickenlj added a commit that referenced this pull request Mar 3, 2021
…tener in ServiceClassPostProcessor, it already register in DubboApplicationListenerRegistrar (#7000)"

This reverts commit f75c22c.
chickenlj added a commit that referenced this pull request Mar 3, 2021
…tener in ServiceClassPostProcessor, it already register in DubboApplicationListenerRegistrar (#7000)" (#7308)

This reverts commit f75c22c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants