fix #7315 redundant box for boolean and refactor method filterInvoker #7316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7316 +/- ##
============================================
- Coverage 59.06% 59.02% -0.04%
+ Complexity 462 460 -2
============================================
Files 1044 1044
Lines 42473 42466 -7
Branches 6228 6224 -4
============================================
- Hits 25085 25064 -21
- Misses 14588 14599 +11
- Partials 2800 2803 +3 Continue to review full report at Codecov.
|
chickenlj
requested changes
Mar 4, 2021
| @@ -160,7 +160,7 @@ public URL getUrl() { | |||
| * @return | |||
| */ | |||
| private <T> List<Invoker<T>> filterUsingStaticTag(List<Invoker<T>> invokers, URL url, Invocation invocation) { | |||
| List<Invoker<T>> result = invokers; | |||
| List<Invoker<T>> result; | |||
There was a problem hiding this comment.
Why remove this assignment?
There was a problem hiding this comment.
Oh, I see, I reviewed the wrong method.
chickenlj
approved these changes
Mar 4, 2021
| @@ -160,7 +160,7 @@ public URL getUrl() { | |||
| * @return | |||
| */ | |||
| private <T> List<Invoker<T>> filterUsingStaticTag(List<Invoker<T>> invokers, URL url, Invocation invocation) { | |||
| List<Invoker<T>> result = invokers; | |||
| List<Invoker<T>> result; | |||
There was a problem hiding this comment.
Oh, I see, I reviewed the wrong method.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7315
What is the purpose of the change
unboxing boolean and refactor method filterInvoker
Brief changelog
1.org.apache.dubbo.rpc.cluster.router.tag.TagRouter#isForceUseTag
Boolean.valueOf -> Boolean.parseBoolean
2.org.apache.dubbo.rpc.cluster.router.tag.TagRouter#filterInvoker
refactor in stream
3.org.apache.dubbo.rpc.cluster.router.tag.TagRouter#filterUsingStaticTag
remove param(result) initial value
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.