Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Use @SPI's wrapper method to report a null pointer exception bug #7326

Merged
merged 6 commits into from
Apr 11, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

fix Use @SPI's wrapper method to report a null pointer exception bug

see more detail from #7176

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 8, 2021

Codecov Report

Merging #7326 (f535a6c) into master (34b744b) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7326      +/-   ##
============================================
- Coverage     59.03%   58.86%   -0.18%     
+ Complexity      462      459       -3     
============================================
  Files          1044     1044              
  Lines         42472    42491      +19     
  Branches       6227     6232       +5     
============================================
- Hits          25074    25011      -63     
- Misses        14594    14658      +64     
- Partials       2804     2822      +18     
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/extension/ExtensionLoader.java 78.17% <100.00%> (-0.13%) 0.00 <0.00> (ø)
...o/common/extension/support/ActivateComparator.java 73.07% <100.00%> (+3.84%) 0.00 <0.00> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-13.80%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/exchange/Request.java 74.50% <0.00%> (-13.73%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 77.77% <0.00%> (-10.26%) 0.00% <0.00%> (ø%)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b744b...f535a6c. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit a10d7f3 into apache:master Apr 11, 2021
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
…pache#7326)

* fix Use @SPI's wrapper method to report a null pointer exception bug. see apache#7176.

(cherry picked from commit df6d6ad)

* fix apache#7176 Use @SPI's wrapper method to report a null pointer exception bug

* recover wildcard import

* delete issue link

* add new spi interface.

* fix testActivateComparator test case.

Co-authored-by: xiaoheng <xiaoyu>

(cherry picked from commit a10d7f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants