Add empty constructor for DubboLifecycleComponentApplicationListener #7357
Conversation
|
|
done |
| @@ -43,6 +43,10 @@ | |||
|
|
|||
| private final DubboBootstrap dubboBootstrap; | |||
|
|
|||
| public DubboBootstrapApplicationListener() { | |||
| this.dubboBootstrap = DubboBootstrap.getInstance(); | |||
There was a problem hiding this comment.
If init by this constructor, the applicationContext in super class OnceApplicationContextEventListener will null, when call getApplicationContext(), cause NPE, I'm not sure this case will be happen.
There was a problem hiding this comment.
hi @horizonzy ,
I am not quite sure which class you mentioned which has getApplicationContext().
I have found there are two places use applicationContext
- OnceApplicationContextEventListener
ApplicationContextAware has been implemented by OnceApplicationContextEventListener, so applicationContext will be automaticly injected by public final void setApplicationContext(ApplicationContext applicationContext) throws BeansException
- DubboBootstrapStartStopListenerSpringAdapter
The methods in DubboBootstrapStartStopListenerSpringAdapter will be called after DubboBootstrap started and before this ApplicationContextEvent will notify DubboLifecycleComponentApplicationListener with applicationContext.
What is the purpose of the change
add empty constructor for DubboLifecycleComponentApplicationListener
related issue #7347